You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/10 15:05:51 UTC

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1276: HDDS-4046. Extensible subcommands for CLI applications

elek commented on a change in pull request #1276:
URL: https://github.com/apache/hadoop-ozone/pull/1276#discussion_r467969399



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/OMAdmin.java
##########
@@ -50,7 +51,7 @@
     subcommands = {
         GetServiceRolesSubcommand.class
     })
-public class OMAdmin extends GenericCli {
+public class OMAdmin extends GenericCli implements SubcommandWithParent {

Review comment:
       Yes, it's missing. :eagle: :eye: :trophy: 
   
   Also, I can remove the `OmAdmin` from the annotations of `OzoneAdmin`. (Fortunately annotations and subcommands added programmatically can work together).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org