You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/06/13 07:21:11 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
BiteTheDDDDt opened a new pull request, #20742:
URL: https://github.com/apache/doris/pull/20742
## Proposed changes
do not make query fail when rf publish failed
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588703873
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227722040
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
Status publish() {
for (auto& pair : _runtime_filters) {
for (auto filter : pair.second) {
- RETURN_IF_ERROR(filter->publish());
+ auto state = filter->publish();
+ if (!state) {
+ // TODO: solve publish failed when scan not schedured
+ LOG(WARNING) << "filter publish failed, reason=" << state.to_string();
Review Comment:
Even if rf publish failed, the query should execute normally.
I changed this behavior in #20593 to cause the workflow to be blocked, now change it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588889937
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588784137
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588704344
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227711232
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
Status publish() {
for (auto& pair : _runtime_filters) {
for (auto filter : pair.second) {
- RETURN_IF_ERROR(filter->publish());
+ auto state = filter->publish();
+ if (!state) {
+ // TODO: solve publish failed when scan not schedured
+ LOG(WARNING) << "filter publish failed, reason=" << state.to_string();
Review Comment:
If state is not ok, why not return error status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227710711
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
Status publish() {
for (auto& pair : _runtime_filters) {
for (auto filter : pair.second) {
- RETURN_IF_ERROR(filter->publish());
+ auto state = filter->publish();
Review Comment:
use status not state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588889878
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20742:
URL: https://github.com/apache/doris/pull/20742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227725363
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
Status publish() {
for (auto& pair : _runtime_filters) {
for (auto filter : pair.second) {
- RETURN_IF_ERROR(filter->publish());
+ auto state = filter->publish();
Review Comment:
This piece of code will be removed in the future, so fix the workflow as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588697066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20742:
URL: https://github.com/apache/doris/pull/20742#issuecomment-1588709021
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org