[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #2059: [KYUUBI #1936] Send credentials when opening session and wait for completion

[GitBox <gi...@apache.org>]

turboFei commented on a change in pull request #2059:
URL: https://github.com/apache/incubator-kyuubi/pull/2059#discussion_r821296751



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/HadoopCredentialsManager.scala
##########
@@ -146,12 +146,13 @@ class HadoopCredentialsManager private (name: String) extends AbstractService(na
   def sendCredentialsIfNeeded(
       sessionId: String,
       appUser: String,
-      send: String => Unit): Unit = {
+      send: String => Unit,
+      waitComplete: Boolean = false): Unit = {

Review comment:
       how about rename `waitComplete` to `onetime`?
   
   In my opinion,
   
   we want to enforce send credentials to engine side one time.
   If it fails, we do not need wait it retry and just provide some prompt(the exception message) for client side.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org