Re: svn commit: r27379 - trunk/tools/backup

[Karl Fogel <kf...@red-bean.com>]

arfrever@tigris.org writes:
> --- trunk/tools/backup/hot-backup.py.in	(original)
> +++ trunk/tools/backup/hot-backup.py.in	Thu Oct 25 11:23:53 2007
> @@ -52,8 +52,8 @@
>  # Path to svnadmin utility
>  svnadmin = r"@SVN_BINDIR@/svnadmin"
>  
> -# Number of backups to keep around (0 for "keep them all")
> -num_backups = 64
> +# Default number of backups to keep around (0 for "keep them all")
> +num_backups = int(os.environ.get("SVN_HOTBACKUP_BACKUPS_NUMBER", 64))
>  
>  # Archive types/extensions
>  archive_map = {
> @@ -111,13 +111,16 @@
>                         bz2 : Creates a bzip2 compressed tar file.
>                         gz  : Creates a gzip compressed tar file.
>                         zip : Creates a compressed zip file.
> +  --num-backups=N    Number of prior backups to keep around (0 for keeping all).
>    --help      -h     Print this help message and exit.
>  
>  """ % (scriptname,))

Thanks for fixing my (incorrect) usage text, since "0" keeps all
rather than none.  But say "0 to keep all" rather than "0 for keeping
all".  The former is idiomatic, and also doesn't bump up against the
80-column limit.

Well, I've just committed the fix in r27407, no problem.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org