[GitHub] sdedic commented on a change in pull request #551: [NETBEANS-777] JDK10-LVTI: Fix for NPE on typing invalid block/javadoc comment just after var keyword

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #551: [NETBEANS-777] JDK10-LVTI: Fix for NPE on typing invalid block/javadoc comment just after var keyword
URL: https://github.com/apache/incubator-netbeans/pull/551#discussion_r189290215
 
 

 ##########
 File path: java.lexer/src/org/netbeans/lib/java/lexer/JavaLexer.java
 ##########
 @@ -1051,7 +1051,12 @@ else if ('0' <= c && c <= '9') { // float literal
 
                                     if (AFTER_VAR_TOKENS.contains(next.id())) {
                                         do {
+                                            if (next.partType() != PartType.COMPLETE) {
 
 Review comment:
   It's rather unexpected usage of PartType, but should work. I would still prefer to just check for `null` after `nextToken()` call, as Javadoc comments can have some embeddings injected which may eventually produce start-middle-end tokens. I am not 100% sure how the token system works in that case.
   
   @jlahoda ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists