You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/20 11:29:50 UTC

[GitHub] liupc opened a new pull request #23845: [SPARK-26941]Fix incorrect computation of maxNumExecutorFailures for streaming

liupc opened a new pull request #23845: [SPARK-26941]Fix incorrect computation of maxNumExecutorFailures for streaming
URL: https://github.com/apache/spark/pull/23845
 
 
   ## What changes were proposed in this pull request?
   
   Currently, when enabled streaming dynamic allocation for streaming applications, the maxNumExecutorFailures in ApplicationMaster is still computed with `spark.dynamicAllocation.maxExecutors`. 
   
   Actually, we should consider `spark.streaming.dynamicAllocation.maxExecutors` instead.
   
   Related codes:
   https://github.com/apache/spark/blob/f87153a3acbab9260db356a451ddae86adba41b2/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala#L101
   
   ## How was this patch tested?
   
   NA
   
   Please review http://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org