You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/25 01:19:40 UTC
Review Request 27181: Allow the invoker to ignore patterns in
git-clean.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Like, i dunno, the credentials file, for example.
Diffs
-----
build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712
Diff: https://reviews.apache.org/r/27181/diff/
Testing
-------
Running.
Thanks,
Bill Farner
Re: Review Request 27181: Allow the invoker to ignore patterns in
git-clean.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 24, 2014, 11:21 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 112
> > <https://reviews.apache.org/r/27181/diff/1/?file=733134#file733134line112>
> >
> > Should've caught this in the first review - dashes instead of underscores, here and above.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/#review58436
-----------------------------------------------------------
On Oct. 24, 2014, 11:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27181/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 11:19 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Like, i dunno, the credentials file, for example.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712
>
> Diff: https://reviews.apache.org/r/27181/diff/
>
>
> Testing
> -------
>
> Running.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27181: Allow the invoker to ignore patterns in
git-clean.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/#review58436
-----------------------------------------------------------
Ship it!
build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27181/#comment99437>
Should've caught this in the first review - dashes instead of underscores, here and above.
- Kevin Sweeney
On Oct. 24, 2014, 4:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27181/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 4:19 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Like, i dunno, the credentials file, for example.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712
>
> Diff: https://reviews.apache.org/r/27181/diff/
>
>
> Testing
> -------
>
> Running.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27181: Allow the invoker to ignore patterns in
git-clean.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 11:25 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Like, i dunno, the credentials file, for example.
Diffs (updated)
-----
build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712
Diff: https://reviews.apache.org/r/27181/diff/
Testing
-------
Running.
Thanks,
Bill Farner
Re: Review Request 27181: Allow the invoker to ignore patterns in
git-clean.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/#review58438
-----------------------------------------------------------
-1: This patch does not apply cleanly on master (f98bec7), do you need to rebase?
- Aurora ReviewBot
On Oct. 24, 2014, 11:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27181/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 11:19 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Like, i dunno, the credentials file, for example.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712
>
> Diff: https://reviews.apache.org/r/27181/diff/
>
>
> Testing
> -------
>
> Running.
>
>
> Thanks,
>
> Bill Farner
>
>