You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/11/17 09:38:00 UTC
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/863
TAJO-1980: Printout the usage of TajoShellCommand
```TajoShellCommand::getUsage()``` is designed for ```TajoShellCommand::printHelp()``` to printout detailed-usage like ```TajoShellCommand::getDescription()```. But, Currently, It's omitted in ```TajoShellCommand::printHelp()```, so ```TajoShellCommand::getUsage()``` has no usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1980
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #863
----
commit f49ae4bd8eef17397d5d1f965abfe4efea5e5d16
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-11-17T08:36:01Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/863#issuecomment-157961866
@blrunner Thanks for your review. I add unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/863#discussion_r45320720
--- Diff: tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java ---
@@ -561,4 +562,26 @@ public void printProgress(PrintWriter sout, QueryStatus status) {
//nothing to do
}
}
+
+ @Test
+ public void testDefaultPrintHelp() throws IOException, NoSuchMethodException {
+ Iterator i = tajoCli.getContext().getCommands().keySet().iterator();
--- End diff --
If you use ```entrySet()``` instead of ```keySet().iterator()```, test codes would be more simple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/863#issuecomment-158329590
+1
LGTM! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/863#issuecomment-157631579
You need to add some unit test cases to ```TestTajoCli``` because this patch will change the result of tsql help command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/863#issuecomment-158260538
@blrunner Thanks for your comment! I make test code little bit more simple using ```entrySet()``` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1980: Printout the usage of TajoShellComma...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/863#issuecomment-157566890
@blrunner Hi! This PR is related to TAJO-1979.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---