You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/10/30 16:40:29 UTC
[Bug 123585] New: AOO 4.0.1 crash when "Random effect" custom
animation selected
https://issues.apache.org/ooo/show_bug.cgi?id=123585
Bug ID: 123585
Issue Type: DEFECT
Summary: AOO 4.0.1 crash when "Random effect" custom animation
selected
Product: Impress
Version: 4.0.1
Hardware: All
OS: Windows 7
Status: CONFIRMED
Severity: normal
Priority: P3
Component: editing
Assignee: issues@openoffice.apache.org
Reporter: r4zoli@apache.org
CC: issues@openoffice.apache.org
Created attachment 81847
--> https://issues.apache.org/ooo/attachment.cgi?id=81847&action=edit
Bugdoc with custom animation
When "Random effect" custom animation selected, the AOO 4.0.1 crashes.
This not happens with AOO 3.4.1, it seems to as regression.
tested under Windows 7.
>From Hungarian forum post:
http://forum.openoffice.org/hu/forum/viewtopic.php?f=8&t=1467 (It is inserted
here only for references).
I can reproduce it under Windows 8.1, the bug confirmed.
To reproduce crash, open attached file, select Test2, add "Random effect" from
"Basic" category. Click to "OK" AOO crash. Document recovery starts. When
recovery finished the file opens, and custom animation on Test2 is set.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
Can reproduce/debug the following way:
- load file from description
- select test2 (press tab, tab)
- switch sidebar to custom animation
- press add, dialog appears
- press 'random effects', preview runs
-> set breakpoint at anaimations/source/animcore/animcore.cxx line 1327
- press OK in custom animation dialog
-> stop at breakpoint
- enter fireChangeListener
- AnimationNode has a parent, follow mpParent->fireChangeListener() once
- step into animcore.cxx line 2093 (the Guard< Mutex > aGuard constructor)
- in osl_acquireMutex() of sal/osl/w32/mutex.c take a look at handed over
parameter Mutex -> it is not initialized (!)
I could not find a way how a AnimationNode can be created with a non-valid
local Mutex. Maybe the mpParent is invalid, the acccording mxParent from which
it is taken (via Uno Tunnel) is a weak reference. Checking this...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
The assert from setting the ClipRegion is not a problem, but a hint that
handling a case in WinSalGraphics::setClipRegion is missing. It may happen when
a Region in form of a Polygon or PolyPoygon is done that this is empty or only
contains empty part-polygons (e.g. have no width/height). Added handling that
as a legal case, it will be equal to calling WinSalGraphics::ResetClipRegion().
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
Edwin Sharp <el...@mail-page.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |elish@mail-page.com
--- Comment #1 from Edwin Sharp <el...@mail-page.com> ---
No crash with
AOO401m5(Build:9714) - Rev. 1524958
2013-09-20 11:54 - Linux x86_64
Debian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
Target Milestone|--- |4.1.0
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
Okay, all asserts cleared and changes done, all committed. Setting to resolved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
Rob Weir <ro...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Severity|normal |major
--- Comment #3 from Rob Weir <ro...@apache.org> ---
Reproduced on Win 8.1 64-bit with AOO 4.0.1 en-US. Crash does not depend on
this particular document. Can reproduce with a fresh new document as well.
Tried some other animation effects and did not see a crash.
Raising priority.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #14 from Armin Le Grand <Ar...@me.com> ---
OOps, the comments from the commits landed in 12355, I had a typo in the
commits...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
There is a AnimationNode with a bad mutex. It seems not initialized, all
members are on 0xfeeefeee in the debug version. Thisis strange since the
AnimationNode looks good and is derived from AnimationNodeBase which has the
Mutex as a member. Added a missing call in one of AnimationNode::AnimationNode
to base class AnimationNodeBase, but makes no difference. AnimationNodeBase has
no defined constructor, it's implicit and should work. Adding one to check
this...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
r4zoli <r4...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |crash, regression
--- Comment #2 from r4zoli <r4...@apache.org> ---
added keyword, crash and regression.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
liuping <do...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |doneyourself@gmail.com
--- Comment #15 from liuping <do...@gmail.com> ---
verify AOO410m1(Build:9750) - Rev. 1570848
Rev.1570848 on windows7 ,pass
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
One assertion is due to https://issues.apache.org/ooo/show_bug.cgi?id=122485
that says 1bit bitmaps do not work anymore on linux (64bit probably), so full
depth is used for mask creation. For win it is okay and I will change the
defines to have 1bit masks back for win.
The others are for AnimationNode mappings which are not a guessed
ParagraphTarget but contain shorts and for OutputDevice::ImplSelectClipRegion
not being able to set a clip region (I will have a 2nd look at the latter one).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
Indeed, adding the following code to AnimationNode::fireChangeListener() is
triggered and makes all work:
if(mpParent)
{
Reference< XInterface > xCheckReference(mxParent);
if(!xCheckReference.is())
{
mpParent = 0;
}
}
Thus it indeed looks as if the parent of an AnimationNode is deleted, but this
is not reflected in other AnimationNodes that reference that node as a parent.
Suggesting that code as a fix.
Alternatively - if someone knows how this happens - maybe
AnimationNode::setParent with an empty reference could be called (if possible),
that would also reset the mpParent member accordingly.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
Taking a look...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Checked usage of mpClipRgnData and if it would need to be deleted in case there
is no ClipRegion (no Rectangle), but no, it is used as a buffer for up to 16
rectangles. Zero is less than 16, so no need to delete. Preparing commit...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
Preparing patch, also looking at some assertions which are triggered during
playing the animations...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123585] AOO 4.0.1 crash when "Random effect" custom animation
selected
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123585
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
Happens at aquire of a local mutex:
Guard< Mutex > aGuard( maMutex );
strange...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.