[jira] [Resolved] (LUCENE-5945) Full cutover to Path api from java.io.File

["Robert Muir (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-5945.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 5.0

I fixed as 5.0. If someone wants to backport, feel free. But I'm focusing on trunk.

> Full cutover to Path api from java.io.File
> ------------------------------------------
>
>                 Key: LUCENE-5945
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5945
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 5.0
>
>         Attachments: LUCENE-5945.patch, LUCENE-5945_core.patch
>
>
> Using NIO2 has a lot of benefits:
> * more fine grained exception handling
> * clearer semantics about what happens
> * additional functionality
> * possibility to work with virtual filesystems, etc.
> We already banned File.delete and switched to Files.delete, I think we should ban File completely (except for some sugar methods that just forward with .toPath, like FSDirectory.open)
> For tests, ideally we go a little further and ban methods like FileSystems.getDefault(). Instead we could exempt LuceneTestCase and ensure all Paths are created via one protected method. This leaves open the possibility to mock up filesystem behavior at a lower level in tests in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org