[GitHub] [qpid-jms] gemmellr commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

[GitBox <gi...@apache.org>]

gemmellr commented on pull request #45:
URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1062882201


   Your latest version is a bit simpler, but for reference I banged together the 'trivial synchronized map' version I was thinking of and some other simplifications and changes from previous feedback:
   https://github.com/gemmellr/qpid-jms/tree/pr45-netty-sharing-simpler
   
   I started it yesterday and didnt rebase so its different than your current version. It also changed the indents in a lot of places as yours are 'wrong' in many cases (3-spaced) so isnt as trivially comparable
   
   It is definitely simpler, though still more elaborate than it initially seemed it might be, because of the needed key + holder loop. I expect that possibly could be simplified too though without e.g some more 'interesting' use of the map (e.g have one holder for everything as key and value, use a 'equals but different' object for the lookups) or even some other data structure (basically its acting more as a set but with a kind of reverse-lookup needed)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org