You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/23 19:01:17 UTC

[GitHub] [tvm] leandron opened a new pull request #7508: [TVMC] rename composite target "acl"

leandron opened a new pull request #7508:
URL: https://github.com/apache/tvm/pull/7508


   In TVMC, renames the `acl` composite target to point to the specific library it represents: `compute-library` ([ref](https://github.com/ARM-software/ComputeLibrary)). It was pointed before that `acl` is quite a generic acronym e.g. https://github.com/apache/tvm/pull/5916, so I'm moving it to the official name.
   
   This PR just renames the mnemonic and adjust tests.
   
   cc @u99127 @mbaret @comaniac 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #7508: [TVMC] rename composite target "acl"

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7508:
URL: https://github.com/apache/tvm/pull/7508#issuecomment-785260685


   when possible, can someone (@mbaret @comaniac) merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7508: [TVMC] rename composite target "acl"

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7508:
URL: https://github.com/apache/tvm/pull/7508#issuecomment-785268008


   Thanks @leandron @mbaret 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac merged pull request #7508: [TVMC] rename composite target "acl"

Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7508:
URL: https://github.com/apache/tvm/pull/7508


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #7508: [TVMC] rename composite target "acl"

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7508:
URL: https://github.com/apache/tvm/pull/7508#issuecomment-785260354


   > On the other hand, I'd prefer to keep the arm_compute_lib in the codegen to make developers clearer.
   
   I'll check whether there is any reason to change in other places, and follow-up if needed, with proper justification. For now we can leave it as is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7508: [TVMC] rename composite target "acl"

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7508:
URL: https://github.com/apache/tvm/pull/7508#issuecomment-785250424


   I googled "compute library" and the first 2-3 results are for ACL so I think it's fine to change the composite target name.
   On the other hand, I'd prefer to keep the arm_compute_lib in the codegen to make developers clearer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org