You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/03/24 01:49:59 UTC

[kudu-CR] consensus: Revert terminal state enforcement of FAILED UNRECOVERABLE 

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9794

to review the following change.


Change subject: consensus: Revert terminal state enforcement of FAILED_UNRECOVERABLE
......................................................................

consensus: Revert terminal state enforcement of FAILED_UNRECOVERABLE

In patch 7b88a42332540ace18ea033439ceac0e7cb68411 FAILED_UNRECOVERABLE
was noted as a terminal state. Todd pointed out that there are certain
corner cases where that may not be the case, such as a replica that
started up on a temporarily-failed or read-only disk, and then was
restarted. In such a case, if the leader was previously unable to evict
that node because of a lack of a majority, the affected replica may
revert to a HEALTHY state.

Change-Id: I2f858af8c578340f7a32b95702b5da7bbe81a675
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 2 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9794/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f858af8c578340f7a32b95702b5da7bbe81a675
Gerrit-Change-Number: 9794
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] consensus: Revert terminal state enforcement of FAILED UNRECOVERABLE

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9794 )

Change subject: consensus: Revert terminal state enforcement of FAILED_UNRECOVERABLE
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f858af8c578340f7a32b95702b5da7bbe81a675
Gerrit-Change-Number: 9794
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 24 Mar 2018 02:10:42 +0000
Gerrit-HasComments: No

[kudu-CR] consensus: Revert terminal state enforcement of FAILED UNRECOVERABLE

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9794 )

Change subject: consensus: Revert terminal state enforcement of FAILED_UNRECOVERABLE
......................................................................

consensus: Revert terminal state enforcement of FAILED_UNRECOVERABLE

In patch 7b88a42332540ace18ea033439ceac0e7cb68411 FAILED_UNRECOVERABLE
was noted as a terminal state. Todd pointed out that there are certain
corner cases where that may not be the case, such as a replica that
started up on a temporarily-failed or read-only disk, and then was
restarted. In such a case, if the leader was previously unable to evict
that node because of a lack of a majority, the affected replica may
revert to a HEALTHY state.

Change-Id: I2f858af8c578340f7a32b95702b5da7bbe81a675
Reviewed-on: http://gerrit.cloudera.org:8080/9794
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/metadata.proto
2 files changed, 2 insertions(+), 14 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f858af8c578340f7a32b95702b5da7bbe81a675
Gerrit-Change-Number: 9794
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>