trafficserver git commit: TS-3287: Close socket to prevent resource leak

[so...@apache.org]

Repository: trafficserver
Updated Branches:
  refs/heads/master d19a88b0d -> 63d25f9ad


TS-3287: Close socket to prevent resource leak

Coverity CID #1021829


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/63d25f9a
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/63d25f9a
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/63d25f9a

Branch: refs/heads/master
Commit: 63d25f9adc9cf2a21f5fdad1600c3b1b8e6127c4
Parents: d19a88b
Author: Phil Sorber <so...@apache.org>
Authored: Thu Feb 5 08:22:29 2015 -0700
Committer: Phil Sorber <so...@apache.org>
Committed: Thu Feb 5 08:22:29 2015 -0700

----------------------------------------------------------------------
 lib/records/RecFile.cc | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/63d25f9a/lib/records/RecFile.cc
----------------------------------------------------------------------
diff --git a/lib/records/RecFile.cc b/lib/records/RecFile.cc
index dbeb8f2..669ec59 100644
--- a/lib/records/RecFile.cc
+++ b/lib/records/RecFile.cc
@@ -168,6 +168,7 @@ RecPipeCreate(const char *base_path, const char *name)
   // set so that child process doesn't inherit our fd
   if (fcntl(listenfd, F_SETFD, 1) < 0) {
     RecLog(DL_Warning, "[RecPipeCreate] fcntl error\n");
+    close(listenfd);
     return REC_HANDLE_INVALID;
   }
 
@@ -178,6 +179,7 @@ RecPipeCreate(const char *base_path, const char *name)
   int optval = 1;
   if (setsockopt(listenfd, SOL_SOCKET, SO_REUSEADDR, (char *) &optval, sizeof(int)) < 0) {
     RecLog(DL_Warning, "[RecPipeCreate] setsockopt error\n");
+    close(listenfd);
     return REC_HANDLE_INVALID;
   }