You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2016/10/11 13:26:45 UTC
tinkerpop git commit: Changed traversal interrupt test to have a
single sideEffect
Repository: tinkerpop
Updated Branches:
refs/heads/master 193db1c2d -> 546ef1c07
Changed traversal interrupt test to have a single sideEffect
The dual .sideEffect().sideEffect() which was unecessary in the first place, started presenting problems after NoOpBarrierStrategy was modified recently. The NoOpBarrierStep was splitting the sideEffect steps with a NoOpBarrierStep which was preventing the state modification in the second sideEffect() to affect the first. This test should pass consistently now. CTR
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/546ef1c0
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/546ef1c0
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/546ef1c0
Branch: refs/heads/master
Commit: 546ef1c079b35d97457cfcc66665bac53eed9a00
Parents: 193db1c
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Tue Oct 11 09:23:28 2016 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Tue Oct 11 09:26:39 2016 -0400
----------------------------------------------------------------------
.../gremlin/process/traversal/TraversalInterruptionTest.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/546ef1c0/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionTest.java
index b0da10e..a3ffaf6 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionTest.java
@@ -88,10 +88,12 @@ public class TraversalInterruptionTest extends AbstractGremlinProcessTest {
// this should ensure VertexStep gets to try to throw the TraversalInterruptedException
Thread.currentThread().interrupt();
}
+ } else {
+ startedIterating.countDown();
}
- })).sideEffect(traverser -> {
- startedIterating.countDown();
- });
+ }));
+ traversal.asAdmin().applyStrategies();
+ printTraversalForm(traversal);
traversal.iterate();
} catch (Exception ex) {
exceptionThrown.set(ex instanceof TraversalInterruptedException);