[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013682#comment-17013682 ] 

ASF GitHub Bot commented on AIRFLOW-5501:
-----------------------------------------

stale[bot] commented on pull request #6124: [AIRFLOW-5501] in_cluster default value in KubernetesPodOperator overwrites configuration
URL: https://github.com/apache/airflow/pull/6124
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> in_cluster default value in KubernetesPodOperator overwrites configuration
> --------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5501
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: 1.10.5
>            Reporter: Quentin Lemaire
>            Priority: Major
>
> Hi!
> The default value of the parameter *in_cluster* of the *kube_client.get_kube_client* function is *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the expected behavior is that when, *in_cluster* is not set, it takes the value in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is False and *in_cluster* is passed as a parameter when calling the *kube_client.get_kube_client* function. Therefore, it changes the expecting behavior by overwritting the default value. When *in_cluster* is not set when initializing *KubernetesPodOperator*, the value of *in_cluster* in *kube_client.get_kube_client* is False and not the value which is in the configuration file.
> It is quite confusing because it can feel like the value in the configuration file is not working properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)