You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/02 05:56:18 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore

sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r402067225
 
 

 ##########
 File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlStateStore.java
 ##########
 @@ -73,7 +74,7 @@
  *
  * @param <T> state object type
  **/
-public class MysqlStateStore<T extends State> implements StateStore<T> {
+public class MysqlStateStore<T extends State> implements StateStore<T>, DatasetStateStore<T> {
 
 Review comment:
   Instead of changing MySqlStateStore (and indeed, other state store implementations), can we have MySqlJobStatusStateStore implement DatasetStateStore interface? Won't that change be more localized?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services