You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/04 20:20:00 UTC
[jira] [Work logged] (HIVE-24415) HiveSplitGenerator blocks Tez
dispatcher
[ https://issues.apache.org/jira/browse/HIVE-24415?focusedWorklogId=530867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530867 ]
ASF GitHub Bot logged work on HIVE-24415:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 20:19
Start Date: 04/Jan/21 20:19
Worklog Time Spent: 10m
Work Description: ramesh0201 commented on a change in pull request #1701:
URL: https://github.com/apache/hive/pull/1701#discussion_r551546406
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java
##########
@@ -100,37 +99,19 @@
private int sourceInfoCount = 0;
- private final Object endOfEvents = new Object();
-
private int totalEventCount = 0;
- public DynamicPartitionPruner(InputInitializerContext context, MapWork work, JobConf jobConf) throws
- SerDeException {
- this.context = context;
- this.work = work;
- this.jobConf = jobConf;
- synchronized (this) {
- initialize();
+ public void prune() throws SerDeException, IOException, InterruptedException, HiveException {
+ if (sourcesWaitingForEvents.isEmpty()) {
+ return;
}
- }
-
- public void prune()
- throws SerDeException, IOException,
- InterruptedException, HiveException {
- synchronized(sourcesWaitingForEvents) {
Review comment:
@mustafaiman I could not follow why we removed the synchronized blocks before accessing sourcesWaitingForEvents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 530867)
Time Spent: 20m (was: 10m)
> HiveSplitGenerator blocks Tez dispatcher
> ----------------------------------------
>
> Key: HIVE-24415
> URL: https://issues.apache.org/jira/browse/HIVE-24415
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> HiveSplitGenerator does a lot of heavyweight operations in its constructor. These operations block AsyncDispatcher in Tez [https://github.com/apache/tez/blob/989d286d09cac7c4e4c5a0e06dd75ea5a6f15478/tez-dag/src/main/java/org/apache/tez/dag/app/dag/RootInputInitializerManager.java#L141] . We should move bulk of initialization out of constructor.
> The only reason of setting up everything in constructor is DynamicPartitionPruner. We can buffer incoming events in HiveSplitGenerator until dynamic partition pruner is initialized.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)