[GitHub] nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r158588248
 
 

 ##########
 File path: server/src/com/cloud/network/guru/PublicNetworkGuru.java
 ##########
 @@ -115,7 +115,11 @@ protected PublicNetworkGuru() {
     protected void getIp(NicProfile nic, DataCenter dc, VirtualMachineProfile vm, Network network) throws InsufficientVirtualNetworkCapacityException,
         InsufficientAddressCapacityException, ConcurrentOperationException {
         if (nic.getIPv4Address() == null) {
-            PublicIp ip = _ipAddrMgr.assignPublicIpAddress(dc.getId(), null, vm.getOwner(), VlanType.VirtualNetwork, null, null, false);
+            boolean forSystemVms = false;
+            if (vm.getType().equals(VirtualMachine.Type.ConsoleProxy) || vm.getType().equals(VirtualMachine.Type.SecondaryStorageVm)) {
+                forSystemVms = true;
 
 Review comment:
   @nitin-maharana sorry for late response, been busy with other tasks. I checked usage of is_system column and are used for static nat or load balancing purposes. Best option should be including this new column.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services