You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/01/30 00:20:43 UTC
Review Request 42984: Add failed result email protocol.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/
-----------------------------------------------------------
Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
Hints of this protocol exist down in step 6 when a release succeeds,
but this places the failure action in-line in the step process to make
it more likely the reader does the right thing.
Also kill an incorrect instruction to send the successful release vote
result email to the private@ list.
docs/committers.md | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
Diffs
-----
docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
Diff: https://reviews.apache.org/r/42984/diff/
Testing
-------
I have no clue if the instructions and provided example link are correct.
I did find variation when reading past [RESULT][VOTE] failures; so
guidance on what is required vs what is personal flair is appreciated.
Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
Thanks,
John Sirois
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
> On Jan. 29, 2016, 4:29 p.m., Bill Farner wrote:
> > docs/committers.md, line 67
> > <https://reviews.apache.org/r/42984/diff/1/?file=1226117#file1226117line67>
> >
> > The `[RESULT][VOTE]` part should become step 5 - successful and failed votes are closed out in the same way.
>
> John Sirois wrote:
> Well, when I reviewed failed vote emails in the past they both do not include a vote tally and may not include the ids of the binding voters in the to.
Basically there is or may be a good deal of ceremony here but from the outside its not clear which bits are ceremony in the emails and which bits are random.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117046
-----------------------------------------------------------
On Jan. 29, 2016, 4:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
> On Jan. 29, 2016, 4:29 p.m., Bill Farner wrote:
> > docs/committers.md, line 67
> > <https://reviews.apache.org/r/42984/diff/1/?file=1226117#file1226117line67>
> >
> > The `[RESULT][VOTE]` part should become step 5 - successful and failed votes are closed out in the same way.
Well, when I reviewed failed vote emails in the past they both do not include a vote tally and may not include the ids of the binding voters in the to.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117046
-----------------------------------------------------------
On Jan. 29, 2016, 4:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 29, 2016, 3:29 p.m., Bill Farner wrote:
> > docs/committers.md, line 67
> > <https://reviews.apache.org/r/42984/diff/1/?file=1226117#file1226117line67>
> >
> > The `[RESULT][VOTE]` part should become step 5 - successful and failed votes are closed out in the same way.
>
> John Sirois wrote:
> Well, when I reviewed failed vote emails in the past they both do not include a vote tally and may not include the ids of the binding voters in the to.
>
> John Sirois wrote:
> Basically there is or may be a good deal of ceremony here but from the outside its not clear which bits are ceremony in the emails and which bits are random.
Whoops, i thought there was no instruction for a result thread of a successful vote. I see now that i overlooked it. LGTM!
No argument about the ceremony - i'm still learning this myself.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117046
-----------------------------------------------------------
On Jan. 29, 2016, 3:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 3:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117046
-----------------------------------------------------------
Fix it, then Ship it!
docs/committers.md (line 67)
<https://reviews.apache.org/r/42984/#comment178112>
The `[RESULT][VOTE]` part should become step 5 - successful and failed votes are closed out in the same way.
- Bill Farner
On Jan. 29, 2016, 3:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 3:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117054
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 29, 2016, 11:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117044
-----------------------------------------------------------
docs/committers.md (line 73)
<https://reviews.apache.org/r/42984/#comment178109>
NB: This instruction is currently broken, but fixing the release script to unbreak the instruction is being done seperately.
- John Sirois
On Jan. 29, 2016, 4:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117064
-----------------------------------------------------------
Ship it!
Master (0eb753d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2016, 11:56 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:56 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
> On Jan. 29, 2016, 5:52 p.m., John Sirois wrote:
> > jfarrell: I'm definitely going to wait on your opinion on this one. I'm viewing you as the expert in this bunch on what the [RFC 2119](https://www.ietf.org/rfc/rfc2119.txt) keywords are for these emails.
I'll take silence as implicit approval / time to move forward and correct later if needed by this evening and submit.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117068
-----------------------------------------------------------
On Jan. 29, 2016, 4:56 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:56 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117068
-----------------------------------------------------------
jfarrell: I'm definitely going to wait on your opinion on this one. I'm viewing you as the expert in this bunch on what the [RFC 2119](https://www.ietf.org/rfc/rfc2119.txt) keywords are for these emails.
- John Sirois
On Jan. 29, 2016, 4:56 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:56 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42984: Add failed result email protocol.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 4:56 p.m.)
Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
Changes
-------
Fix tab.
docs/committers.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Repository: aurora
Description
-------
Hints of this protocol exist down in step 6 when a release succeeds,
but this places the failure action in-line in the step process to make
it more likely the reader does the right thing.
Also kill an incorrect instruction to send the successful release vote
result email to the private@ list.
docs/committers.md | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
Diffs (updated)
-----
docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
Diff: https://reviews.apache.org/r/42984/diff/
Testing
-------
I have no clue if the instructions and provided example link are correct.
I did find variation when reading past [RESULT][VOTE] failures; so
guidance on what is required vs what is personal flair is appreciated.
Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
Thanks,
John Sirois
Re: Review Request 42984: Add failed result email protocol.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117053
-----------------------------------------------------------
Ship it!
Master (0eb753d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2016, 11:20 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:20 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
>
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
>
> docs/committers.md | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4
>
> Diff: https://reviews.apache.org/r/42984/diff/
>
>
> Testing
> -------
>
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
>
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
>
>
> Thanks,
>
> John Sirois
>
>