You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/12/07 09:17:25 UTC
[GitHub] [knox] anyorey opened a new pull request, #659: fix validation errors of getPID: return 0 when the process started
anyorey opened a new pull request, #659:
URL: https://github.com/apache/knox/pull/659
## What changes were proposed in this pull request?
In some cases getPID will return 0 even if the process started. e.g. pid file is deleted or file is modified and we can not get
correct pid from the file. So I add a new function getPidByCommand. It will give the correct pid (APP_GATEWAY_PID ) if process is started. And we'll check the process whether it is started according to APP_PID obtained from pid file ,if it return false ,use APP_GATEWAY_PID . set APP_PID=$APP_GATEWAY_PID.In this way,we can get correct messagge whether the gateway or ldap process is started
## How was this patch tested?
1. start gateway or ldap process
2. delete pid file or modify the content in file
3. execute gateway.sh status or ldap.sh status . It will return correct message
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on PR #659:
URL: https://github.com/apache/knox/pull/659#issuecomment-1340625464
/rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] pzampino commented on pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
pzampino commented on PR #659:
URL: https://github.com/apache/knox/pull/659#issuecomment-1359926050
@anyorey Are you experiencing deletion/modification of the Knox PID files as a regular occurrence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 closed pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
smolnar82 closed pull request #659: fix validation errors of getPID: return 0 when the process started
URL: https://github.com/apache/knox/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 closed pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
smolnar82 closed pull request #659: fix validation errors of getPID: return 0 when the process started
URL: https://github.com/apache/knox/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on PR #659:
URL: https://github.com/apache/knox/pull/659#issuecomment-1369060888
Let's close this now and have it re-opened once @anyorey has time to reply to the above question and can rebase this PR on top of the current `master` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #659: fix validation errors of getPID: return 0 when the process started
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on PR #659:
URL: https://github.com/apache/knox/pull/659#issuecomment-1333525746
@anyorey - Could you please rebase your change so that it'll trigger the necessary `GitHub Actions` builds? I'm going to review this one soon and get back to you.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org