You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/18 08:58:38 UTC

[GitHub] [iotdb] weizihan0110 commented on pull request #2691: [ISSUE-2687] fix insert NaN bug

weizihan0110 commented on pull request #2691:
URL: https://github.com/apache/iotdb/pull/2691#issuecomment-781190472


   > Fix the issue #2687 part 2.
   > 
   > This PR has:
   > 
   > * [ ]  been self-reviewed.
   >   
   >   * [ ]  concurrent read
   >   * [ ]  concurrent write
   >   * [ ]  concurrent read and write
   > * [ ]  added documentation for new or modified features or behaviors.
   > * [ ]  added Javadocs for most classes and all non-trivial methods.
   > * [ ]  added or updated version, **license**, or notice information
   > * [ ]  added comments explaining the "why" and the intent of the code wherever would not be obvious
   >   for an unfamiliar reader.
   > * [ ]  added unit tests or modified existing tests to cover new code paths, ensuring the threshold
   >   for code coverage.
   > * [ ]  added integration tests.
   > * [ ]  been tested in a test IoTDB cluster.
   > 
   > ##### Key changed/added classes (or packages if there are too many classes) in this PR
   
   Hi, @HTHou:
       Something like the pic below also should be modified: 
   ![image](https://user-images.githubusercontent.com/15262869/108332170-79955000-720a-11eb-949e-f02184bb1158.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org