You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/07 20:54:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #18072: Change id collation for MySQL to case-sensitive
potiuk opened a new pull request #18072:
URL: https://github.com/apache/airflow/pull/18072
For quite some time we recommended MySQL collation to be
utf8mb3_general_ci in order to avoid too-large-index size. Turns
out that this collation is .... case-insensitive (that's where
ci stands for) this causes problems in case of renaming
tags (!) where only the case differs (Test -> test) as those
tags are considered equal (!). It would also cause problems if
there were several DAGs with ids differing by case only.
Moreoever ... there is no "cs" (case sensitive) collation for
utf8 for MySQL as this is apparently a hard problem:
https://stackoverflow.com/questions/4558707/case-sensitive-collation-in-mysql
The solution in this PR is to change collation to utf8mb3_bin -
it messes up with ORDER BY, but this is not a big problem for ID
kind of values.
Fixes: #17897
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18072: Change id collation for MySQL to case-sensitive
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18072:
URL: https://github.com/apache/airflow/pull/18072#issuecomment-914668029
BTW. It's generally green (just mssql failure). Would love to merge it and forget about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18072: Change id collation for MySQL to case-sensitive
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18072:
URL: https://github.com/apache/airflow/pull/18072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18072: Change id collation for MySQL to case-sensitive
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18072:
URL: https://github.com/apache/airflow/pull/18072#issuecomment-914683841
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18072: Change id collation for MySQL to case-sensitive
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18072:
URL: https://github.com/apache/airflow/pull/18072#issuecomment-914666848
This is the last nail. Please. Let the MySQL encoding madness end ... For anyone interested in my rant about the MySQL encoding, here: https://github.com/apache/airflow/issues/17897#issuecomment-914664135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org