You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/03/26 06:03:26 UTC
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 26, 2015, 10:33 a.m.)
Review request for lens.
Summary (updated)
-----------------
LENS-412: Provide timeline implementation that stores ranges of presence.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description (updated)
-------
1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
2. Use this timeline to store all absent partitions in `StorageTableResolver`.
3. Missing Partition should take precedence over No storage table found.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 26, 2015, 11:56 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 363
> > <https://reviews.apache.org/r/32388/diff/7/?file=906462#file906462line363>
> >
> > If the missing partitions send to user a range now?
Yes.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77870
-----------------------------------------------------------
On March 26, 2015, 10:33 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 10:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
> 2. Use this timeline to store all absent partitions in `StorageTableResolver`.
> 3. Missing Partition should take precedence over No storage table found.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
> lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
> [INFO] Lens .............................................. SUCCESS [1.828s]
> [INFO] Lens API .......................................... SUCCESS [5.302s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
> [INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
> [INFO] Lens DB storage ................................... SUCCESS [10.082s]
> [INFO] Lens Query Library ................................ SUCCESS [4.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.116s]
> [INFO] Lens client ....................................... SUCCESS [20.821s]
> [INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
> [INFO] Lens Examples ..................................... SUCCESS [0.877s]
> [INFO] Lens Distribution ................................. SUCCESS [10.239s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
> [INFO] Lens Regression ................................... SUCCESS [0.460s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:14.098s
> [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
> [INFO] Final Memory: 109M/1216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77870
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java
<https://reviews.apache.org/r/32388/#comment126199>
Is the begin and end inclusive or exclusive? Can you add comments?
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java
<https://reviews.apache.org/r/32388/#comment126200>
Can this be used to persist timeline cache for table, similar to EndsHoles?
If so, is it possible to change from EndsHoles to this? and how?
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/32388/#comment126201>
Needs change - Collections.singleton("blah")
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/32388/#comment126205>
Can you update the comment here with current changes?
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/32388/#comment126202>
If the missing partitions send to user a range now?
- Amareshwari Sriramadasu
On March 26, 2015, 5:03 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 5:03 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
> 2. Use this timeline to store all absent partitions in `StorageTableResolver`.
> 3. Missing Partition should take precedence over No storage table found.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
> lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
> [INFO] Lens .............................................. SUCCESS [1.828s]
> [INFO] Lens API .......................................... SUCCESS [5.302s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
> [INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
> [INFO] Lens DB storage ................................... SUCCESS [10.082s]
> [INFO] Lens Query Library ................................ SUCCESS [4.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.116s]
> [INFO] Lens client ....................................... SUCCESS [20.821s]
> [INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
> [INFO] Lens Examples ..................................... SUCCESS [0.877s]
> [INFO] Lens Distribution ................................. SUCCESS [10.239s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
> [INFO] Lens Regression ................................... SUCCESS [0.460s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:14.098s
> [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
> [INFO] Final Memory: 109M/1216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review78024
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 27, 2015, 7:28 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:28 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
> 2. Use this timeline to store all absent partitions in `StorageTableResolver`.
> 3. Missing Partition should take precedence over No storage table found.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
> lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.088s]
> [INFO] Lens .............................................. SUCCESS [1.955s]
> [INFO] Lens API .......................................... SUCCESS [5.793s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.149s]
> [INFO] Lens Cube ......................................... SUCCESS [2:08.785s]
> [INFO] Lens DB storage ................................... SUCCESS [10.945s]
> [INFO] Lens Query Library ................................ SUCCESS [4.685s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.479s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.688s]
> [INFO] Lens Server ....................................... SUCCESS [4:25.740s]
> [INFO] Lens client ....................................... SUCCESS [20.502s]
> [INFO] Lens CLI .......................................... SUCCESS [2:41.345s]
> [INFO] Lens Examples ..................................... SUCCESS [0.849s]
> [INFO] Lens Distribution ................................. SUCCESS [10.044s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.189s]
> [INFO] Lens Regression ................................... SUCCESS [0.500s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:56.743s
> [INFO] Finished at: Thu Mar 26 10:39:21 UTC 2015
> [INFO] Final Memory: 99M/898M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 27, 2015, 12:58 p.m.)
Review request for lens.
Changes
-------
merge with master
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
2. Use this timeline to store all absent partitions in `StorageTableResolver`.
3. Missing Partition should take precedence over No storage table found.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.088s]
[INFO] Lens .............................................. SUCCESS [1.955s]
[INFO] Lens API .......................................... SUCCESS [5.793s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.149s]
[INFO] Lens Cube ......................................... SUCCESS [2:08.785s]
[INFO] Lens DB storage ................................... SUCCESS [10.945s]
[INFO] Lens Query Library ................................ SUCCESS [4.685s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.479s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.688s]
[INFO] Lens Server ....................................... SUCCESS [4:25.740s]
[INFO] Lens client ....................................... SUCCESS [20.502s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.345s]
[INFO] Lens Examples ..................................... SUCCESS [0.849s]
[INFO] Lens Distribution ................................. SUCCESS [10.044s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.189s]
[INFO] Lens Regression ................................... SUCCESS [0.500s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:56.743s
[INFO] Finished at: Thu Mar 26 10:39:21 UTC 2015
[INFO] Final Memory: 99M/898M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77891
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 26, 2015, 10:40 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 10:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
> 2. Use this timeline to store all absent partitions in `StorageTableResolver`.
> 3. Missing Partition should take precedence over No storage table found.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
> lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.088s]
> [INFO] Lens .............................................. SUCCESS [1.955s]
> [INFO] Lens API .......................................... SUCCESS [5.793s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.149s]
> [INFO] Lens Cube ......................................... SUCCESS [2:08.785s]
> [INFO] Lens DB storage ................................... SUCCESS [10.945s]
> [INFO] Lens Query Library ................................ SUCCESS [4.685s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.479s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.688s]
> [INFO] Lens Server ....................................... SUCCESS [4:25.740s]
> [INFO] Lens client ....................................... SUCCESS [20.502s]
> [INFO] Lens CLI .......................................... SUCCESS [2:41.345s]
> [INFO] Lens Examples ..................................... SUCCESS [0.849s]
> [INFO] Lens Distribution ................................. SUCCESS [10.044s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.189s]
> [INFO] Lens Regression ................................... SUCCESS [0.500s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:56.743s
> [INFO] Finished at: Thu Mar 26 10:39:21 UTC 2015
> [INFO] Final Memory: 99M/898M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 26, 2015, 4:10 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
2. Use this timeline to store all absent partitions in `StorageTableResolver`.
3. Missing Partition should take precedence over No storage table found.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.088s]
[INFO] Lens .............................................. SUCCESS [1.955s]
[INFO] Lens API .......................................... SUCCESS [5.793s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.149s]
[INFO] Lens Cube ......................................... SUCCESS [2:08.785s]
[INFO] Lens DB storage ................................... SUCCESS [10.945s]
[INFO] Lens Query Library ................................ SUCCESS [4.685s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.479s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.688s]
[INFO] Lens Server ....................................... SUCCESS [4:25.740s]
[INFO] Lens client ....................................... SUCCESS [20.502s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.345s]
[INFO] Lens Examples ..................................... SUCCESS [0.849s]
[INFO] Lens Distribution ................................. SUCCESS [10.044s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.189s]
[INFO] Lens Regression ................................... SUCCESS [0.500s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:56.743s
[INFO] Finished at: Thu Mar 26 10:39:21 UTC 2015
[INFO] Final Memory: 99M/898M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 26, 2015, 3:59 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
2. Use this timeline to store all absent partitions in `StorageTableResolver`.
3. Missing Partition should take precedence over No storage table found.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: Provide timeline implementation
that stores ranges of presence.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 26, 2015, 3:39 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
1. `RangesPartitionTimeline.java`: implementation of PartitionTimeline that stores ranges
2. Use this timeline to store all absent partitions in `StorageTableResolver`.
3. Missing Partition should take precedence over No storage table found.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 8758986b6d67d965da3c2ad642becc6b87074459
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 3e323e1ea40ab6e341b82162cbe610d601ff6bf7
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimelineFactory.java 5626a039678fa181567d3d05973db4e9c1870856
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8f8b03a6cad8718341d6e5c0269c7db49aafb21b
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal