You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/05 00:49:28 UTC
[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards
codecov-io commented on issue #4760: URL shortner for dashboards
URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=h1) Report
> Merging [#4760](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc) will **increase** coverage by `0.2%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4760 +/- ##
=========================================
+ Coverage 72.39% 72.59% +0.2%
=========================================
Files 205 206 +1
Lines 15394 15423 +29
Branches 1182 1188 +6
=========================================
+ Hits 11144 11197 +53
+ Misses 4247 4223 -24
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set/assets/javascripts/dashboard/dashboardUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9kYXNoYm9hcmRVdGlscy5qcw==) | `100% <100%> (ø)` | |
| [...assets/javascripts/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `55.88% <100%> (+1.33%)` | :arrow_up: |
| [...cripts/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100% <100%> (ø)` | :arrow_up: |
| [...sets/javascripts/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `95.83% <100%> (ø)` | |
| [...ets/javascripts/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `69.71% <27.27%> (-2.85%)` | :arrow_down: |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <0%> (-1.55%)` | :arrow_down: |
| [...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==) | `99.24% <0%> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.3% <0%> (+0.05%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.48% <0%> (+2.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=footer). Last update [9a79d33...953d2bf](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services