You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2018/12/31 12:01:03 UTC
[Bug 63047] New: Make POILogger subclassable
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047
Bug ID: 63047
Summary: Make POILogger subclassable
Product: POI
Version: 4.0.x-dev
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: fanningpj@yahoo.com
Target Milestone: ---
POILogger/POILogFactory has a mechanism to allow users override the default
logger. One problem is that POILogger needs to be subclassed but the contructor
is not public - so users have to create the subclass in the org.apache.poi.util
package.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63047] Make POILogger subclassable
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047
Andreas Beeker <ki...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Andreas Beeker <ki...@apache.org> ---
Sorry to hijack that issue - but just when I wanted to commit the code and open
a ticket before/for it - you've created it already ...
I think the cleaner way is to use an interface instead of abstract class.
Anything else should be the same.
Applied via r1850040
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63047] Make POILogger subclassable
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63047
--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
Strictly speaking the latest revision is a breaking API change. Users who may
have created their own subclasses of POILogger will find that code will not
compile with this change.
All that said, I think the intent is that the next release is 4.1.0 (as opposed
to 4.0.2) - so it should be more acceptable to break APIs, particularly ones
that are unlikely to affect many users.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org