You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mod_python-dev@quetz.apache.org by "Jim Gallacher (JIRA)" <ji...@apache.org> on 2005/08/09 20:08:35 UTC
[jira] Commented: (MODPYTHON-70) Add configure --with-max-locks option to set MAX_LOCKS.
[ http://issues.apache.org/jira/browse/MODPYTHON-70?page=comments#action_12318192 ]
Jim Gallacher commented on MODPYTHON-70:
----------------------------------------
Changes committed. This issue can be closed.
> Add configure --with-max-locks option to set MAX_LOCKS.
> -------------------------------------------------------
>
> Key: MODPYTHON-70
> URL: http://issues.apache.org/jira/browse/MODPYTHON-70
> Project: mod_python
> Type: New Feature
> Components: core
> Versions: 3.2.0
> Environment: All
> Reporter: Jim Gallacher
> Priority: Trivial
>
> MAX_LOCKS in src/include/mod_python.h is currently hard coded (currently 32).
> Since the number of mutexes on some systems is limited, users may prefer to use a different number when compiling mod_python.
> The now configure would be --with-max-locks=INTERGER.
> eg.
> $ ./configure --with-max-locks=4
> The default should also be lower than 32. Grisha has suggested 8.
> I'll commit the changes shortly.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (MODPYTHON-70) Add configure --with-max-locks
option to set MAX_LOCKS.
Posted by "Gregory (Grisha) Trubetskoy" <gr...@apache.org>.
On Tue, 9 Aug 2005, Jim Gallacher wrote:
>> My question is : should we keep on with ./configure ; make ; make install
>> or try to do everything in setup.py ?
>>
>
> As long as we can put setup.py in a Makefile. ;)
>
> Seriously though, ./configure --help; ./configure; make; make install; is
> just such second nature to me I never even thought of the alternative.
Yep, and I think setup.py isn't smart enough to deal with the Apache side
of mod_python which is C-centric. But in any event, I think ./configure is
the way to go.
Grisha
Re: [jira] Commented: (MODPYTHON-70) Add configure --with-max-locks
option to set MAX_LOCKS.
Posted by Jim Gallacher <jg...@sympatico.ca>.
Nicolas Lehuen wrote:
> This raise this issue : under Win32, the preferred way to build
> mod_python is to run :
>
> python setup.py.in <http://setup.py.in> bdist_wininst --install-script
> win32_postinstall.py
>
> This leaves no room to specify a MAX_LOCK definition override, but I
> guess we could put it in setup.py, since extension modules can have
> custome macro definitions.
>
> My question is : should we keep on with ./configure ; make ; make
> install or try to do everything in setup.py ?
>
As long as we can put setup.py in a Makefile. ;)
Seriously though, ./configure --help; ./configure; make; make install;
is just such second nature to me I never even thought of the alternative.
I'm still a little puzzled about the current setup.py though, because it
gets configuration information from config.status, which is generated by
./configure. I guess that's another story.
import this
"There should be one-- and preferably only one --obvious way to do it."
So if distutils can do the job, with the same functionality, and be
cross platform friendly then I'm all for it (but not in 3.2.0), even if
it means breaking my Makefile habit. It does not make sense to spend our
time maintaining 2 different build methods. (And it's a chance for me to
learn the distutils black magic).
Regards,
Jim
Re: [jira] Commented: (MODPYTHON-70) Add configure --with-max-locks option to set MAX_LOCKS.
Posted by Nicolas Lehuen <ni...@gmail.com>.
This raise this issue : under Win32, the preferred way to build mod_python
is to run :
python setup.py.in <http://setup.py.in> bdist_wininst --install-script
win32_postinstall.py
This leaves no room to specify a MAX_LOCK definition override, but I guess
we could put it in setup.py, since extension modules can have custome macro
definitions.
My question is : should we keep on with ./configure ; make ; make install or
try to do everything in setup.py ?
Regards,
Nicolas
2005/8/9, Jim Gallacher (JIRA) <ji...@apache.org>:
>
> [
> http://issues.apache.org/jira/browse/MODPYTHON-70?page=comments#action_12318192]
>
> Jim Gallacher commented on MODPYTHON-70:
> ----------------------------------------
>
> Changes committed. This issue can be closed.
>
> > Add configure --with-max-locks option to set MAX_LOCKS.
> > -------------------------------------------------------
> >
> > Key: MODPYTHON-70
> > URL: http://issues.apache.org/jira/browse/MODPYTHON-70
> > Project: mod_python
> > Type: New Feature
> > Components: core
> > Versions: 3.2.0
> > Environment: All
> > Reporter: Jim Gallacher
> > Priority: Trivial
>
> >
> > MAX_LOCKS in src/include/mod_python.h is currently hard coded (currently
> 32).
> > Since the number of mutexes on some systems is limited, users may prefer
> to use a different number when compiling mod_python.
> > The now configure would be --with-max-locks=INTERGER.
> > eg.
> > $ ./configure --with-max-locks=4
> > The default should also be lower than 32. Grisha has suggested 8.
> > I'll commit the changes shortly.
> >
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>