You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ingmar Kliche (JIRA)" <ji...@apache.org> on 2008/12/02 22:34:44 UTC
[jira] Created: (SCXML-98) TestCases should use SCXMLParser
TestCases should use SCXMLParser
--------------------------------
Key: SCXML-98
URL: https://issues.apache.org/jira/browse/SCXML-98
Project: Commons SCXML
Issue Type: Bug
Affects Versions: 0.8
Reporter: Ingmar Kliche
The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-98) TestCases should use SCXMLParser
Posted by "Ingmar Kliche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652996#action_12652996 ]
Ingmar Kliche commented on SCXML-98:
------------------------------------
I agree that we should leave a couple of test cases for the digester. My proposal is
1) to change the getExecutor() implementations (of SCXMLTestHelper) to use the parser and
2) to move all digester test cases into the single (specifically named) "SCXMLDigesterTest" class
We may want to implement the same test cases (which we leave for the digester) for the parser. Would we want to have separate SCXML documents in this case for the digester and the parser test cases (i.e. a microwave01_digester.xml and a microwave01.xml)?
> TestCases should use SCXMLParser
> --------------------------------
>
> Key: SCXML-98
> URL: https://issues.apache.org/jira/browse/SCXML-98
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Ingmar Kliche
> Fix For: 0.10
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-98) TestCases should use SCXMLParser
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SCXML-98:
-------------------------------
Affects Version/s: (was: 0.8)
0.9
Fix Version/s: 0.10
We already do that in the J6 branch: http://svn.apache.org/repos/asf/commons/proper/scxml/branches/J6/
We do some of that in trunk (newer tests use the SCXMLParser). It might be better to port most of the tests to use the SCXMLParser as you say, but I'd leave a couple for the SCXMLDigester as well (we want to test it even if its deprecated, until it is removed in v1.0).
Please provide a patch to move more tests in trunk to using the SCXMLParser if possible (necessary changes to the test cases can be seen in the J6 branch, so its mostly a matter of porting changes to trunk).
Tentatively setting fix version to next release v0.10.
> TestCases should use SCXMLParser
> --------------------------------
>
> Key: SCXML-98
> URL: https://issues.apache.org/jira/browse/SCXML-98
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Ingmar Kliche
> Fix For: 0.10
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-98) TestCases should use SCXMLParser
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653019#action_12653019 ]
Rahul Akolkar commented on SCXML-98:
------------------------------------
Thanks for the concrete proposal.
1) Yes, we'd use SCXMLTestHelper#parse() methods instead of corresponding #digest() methods. The SCXML test documents may need corresponding tweaks as well.
2) Yes, but we already have such a class so we'd change it as needed: http://svn.apache.org/repos/asf/commons/proper/scxml/trunk/src/test/java/org/apache/commons/scxml/io/SCXMLDigesterTest.java
And finally, if its only a couple of tests for the deprecated SCXMLDigester class, I don't mind the duplicate SCXML documents (obviously, we don't want to go from N documents to 2*N documents, but N+2 seems OK :-).
> TestCases should use SCXMLParser
> --------------------------------
>
> Key: SCXML-98
> URL: https://issues.apache.org/jira/browse/SCXML-98
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Ingmar Kliche
> Fix For: 0.10
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-98) TestCases should use SCXMLParser
Posted by "Ingmar Kliche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ingmar Kliche updated SCXML-98:
-------------------------------
Attachment: SCXML-98.patch.txt
SCXMLTestHelper#getExecutor() implementations now make use of the SCXMLParser.
In some test cases I had to move <var> into the "cs" namespace and to add some "initial" attributes on compound states. The test case documents which are shared between parser and digester test cases make use of the <initial> tag instead of the initial attribute.
> TestCases should use SCXMLParser
> --------------------------------
>
> Key: SCXML-98
> URL: https://issues.apache.org/jira/browse/SCXML-98
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Ingmar Kliche
> Fix For: 0.10
>
> Attachments: SCXML-98.patch.txt
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SCXML-98) TestCases should use SCXMLParser
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar resolved SCXML-98.
--------------------------------
Resolution: Fixed
Thanks, I've applied a variant of the patch (I added two legacy documents in SVN rather than reuse the old ones with both versions of the parser -- this ensures that the newer versions don't have any legacy flavor to them).
> TestCases should use SCXMLParser
> --------------------------------
>
> Key: SCXML-98
> URL: https://issues.apache.org/jira/browse/SCXML-98
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Ingmar Kliche
> Fix For: 0.10
>
> Attachments: SCXML-98.patch.txt
>
>
> The SCXMLParser implements the latest SCXML parsing rules, whereas the SCXMLDigester is deprecated. But a lot of testcases still rely on the SCXMLDigester (indirectly) by using SCXMLTestHelper::getExecutor(url). The testHelper implementation should use the SCXMLParser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.