[GitHub] [geode] mhansonp commented on a diff in pull request #7600: GEODE-10283: Remove problematic buildSrc project, replacing with includeBuild projects

[GitBox <gi...@apache.org>]

mhansonp commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r870509656


##########
build-tools/geode-testing-isolation/src/test/java/org/apache/geode/gradle/test/isolation/PortRangeTest.java:
##########
@@ -16,31 +16,28 @@
 package org.apache.geode.gradle.test.isolation;
 
 import static java.util.stream.Collectors.toList;
-import static org.junit.Assert.assertTrue;
 
 import java.util.List;
 import java.util.stream.IntStream;
 
-import org.junit.Test;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-
 import org.apache.geode.gradle.testing.isolation.PortRange;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
 public class PortRangeTest {
   @Test
   public void firstPartitionHasSameLowerBoundAsFullRange() {
     PortRange fullRange = new PortRange(11111, 19994); // Arbitrary
     PortRange firstPartition = fullRange.partition(0, 24);
-    assertEquals(fullRange.lowerBound(), firstPartition.lowerBound());
+    Assertions.assertEquals(fullRange.lowerBound(), firstPartition.lowerBound());

Review Comment:
   Please use assertThat. We are no longer using assertEquals.



##########
build-tools/scripts/src/main/groovy/code-analysis.gradle:
##########
@@ -15,61 +15,56 @@
  * limitations under the License.
  */
 
-if (project.hasProperty("staticAnalysis")) {
-  apply plugin: 'checkstyle'
+plugins {
+  // Findbugs has been removed as of Gradle 6. Spotbugs is an alternative, if anyone wants to enable it.
+//  id 'com.github.spotbugs'
+  id 'jacoco'
+}
 
-  //Checkstyle configuration
-  configurations.checkstyle {
-    dependencies.all { dep ->
-      dep.transitive = true
+// JaCoCo configuration
+def jacocoOff = {
+  it.configure {
+    jacoco {
+      enabled = false
     }
   }
-
-  //Findbugs configuration
-  apply plugin: 'findbugs'

Review Comment:
   Does JaCoCo take care of the xml and html review now in a way it didn't before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org