You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/28 03:15:13 UTC
[GitHub] [shardingsphere-elasticjob] qaqLjj opened a new pull request #1792: FIX: The spring-boot-starter-jdbc is not optional in ElasticJob Sprin…
qaqLjj opened a new pull request #1792:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1792
…g Boot Starter
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1792: FIX: The spring-boot-starter-jdbc is not optional in ElasticJob Sprin…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1792:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1792#issuecomment-751560924
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=h1) Report
> Merging [#1792](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=desc) (5100181) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/19e490e3fde7f08c0a527beec558ba5c277d36a5?el=desc) (19e490e) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1792 +/- ##
============================================
+ Coverage 85.86% 85.91% +0.05%
+ Complexity 113 112 -1
============================================
Files 274 274
Lines 5923 5923
Branches 907 907
============================================
+ Hits 5086 5089 +3
Misses 507 507
+ Partials 330 327 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <0.00%> (+1.58%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <0.00%> (+4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `100.00% <0.00%> (+20.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=footer). Last update [19e490e...5100181](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1792: FIX: The spring-boot-starter-jdbc is not optional in ElasticJob Sprin…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1792:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1792#issuecomment-751560924
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=h1) Report
> Merging [#1792](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=desc) (5100181) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/19e490e3fde7f08c0a527beec558ba5c277d36a5?el=desc) (19e490e) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1792 +/- ##
============================================
+ Coverage 85.86% 85.91% +0.05%
+ Complexity 113 112 -1
============================================
Files 274 274
Lines 5923 5923
Branches 907 907
============================================
+ Hits 5086 5089 +3
Misses 507 507
+ Partials 330 327 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <0.00%> (+1.58%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <0.00%> (+4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `100.00% <0.00%> (+20.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=footer). Last update [19e490e...5100181](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1792?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1792: FIX: The spring-boot-starter-jdbc is not optional in ElasticJob Sprin…
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #1792:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org