You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/09/18 14:46:27 UTC
[GitHub] [cordova-ios] Anuj-Raghuvanshi opened a new pull request #989: Fix - WKWebView doesn't layout properly at initial launch (CB-13987)
Anuj-Raghuvanshi opened a new pull request #989:
URL: https://github.com/apache/cordova-ios/pull/989
- When App is installed and run, it was adding extra space from footer.
Although it was getting fixed on next app launch.
### Platforms affected
iOS
### Motivation and Context
WKWebview was adding extra space at footer section at initial launch when app is installed in device. Getting fixed when app is killed and re-launched.
Issue - https://issues.apache.org/jira/browse/CB-13987
### Testing
Tested in iPhone XR.
Earlier I've forked `cordova-plugin-wkwebview-engine` plugin and was using that, But now I've updated to cordova-ios@6.0.0 so its needs to be fixed here now. This fix works correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue closed pull request #989: Fix - WKWebView doesn't layout properly at initial launch (CB-13987)
Posted by GitBox <gi...@apache.org>.
dpogue closed pull request #989:
URL: https://github.com/apache/cordova-ios/pull/989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on pull request #989: Fix - WKWebView doesn't layout properly at initial launch (CB-13987)
Posted by GitBox <gi...@apache.org>.
dpogue commented on pull request #989:
URL: https://github.com/apache/cordova-ios/pull/989#issuecomment-694921045
We've rejected this change several times, because control over the safe area insets should be up to the app developer using the `viewport-fit` meta tag. Cordova should not override developers' control over their apps.
The usual cause of these layout issues is setting `height: 100%` or `min-height: 100%` on the body element.
`100%` and `100vh` behave differently with safe area insets, and `100vh` is almost always what people want:
* **`100%`:** Take up 100% of the space within the safe area insets
* **`100vh`:** Take up 100% of the screen height
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org