[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6169: AWS,Core: Add S3 REST Signer client + REST Spec

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #6169:
URL: https://github.com/apache/iceberg/pull/6169#discussion_r1021760449


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -261,6 +267,8 @@ public class AwsProperties implements Serializable {
 
   public static final boolean S3_CHECKSUM_ENABLED_DEFAULT = false;
 
+  public static final String S3_SIGNER_CLASS = "s3.signer.class";

Review Comment:
   based on the convention we have been using, I think we prefer to call this config signer-impl?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org