You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (JIRA)" <ji...@apache.org> on 2017/07/10 16:28:00 UTC

[jira] [Created] (AIRFLOW-1393) Enable Python3 tests on contrib Spark Submit Hook

Ash Berlin-Taylor created AIRFLOW-1393:
------------------------------------------

             Summary: Enable Python3 tests on contrib Spark Submit Hook
                 Key: AIRFLOW-1393
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1393
             Project: Apache Airflow
          Issue Type: Bug
          Components: tests
            Reporter: Ash Berlin-Taylor
            Priority: Minor


The unit tests in {{tests/contrib/hooks/test_spark_submit_hook.py}} currently skip if run in Python3 because some test cases  loop forever due to a mismatch/misunderstanding about bytes vs string (i.e. the mocked data for {{subprocess.Popen}} doesn't behave the same as actually running Popen)

The fix is to use bytes and {{six.ByteIO}} so that the tests work on Py2 and Py3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)