You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "daniel-p-carvalho (via GitHub)" <gi...@apache.org> on 2025/01/03 12:59:32 UTC

[PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

daniel-p-carvalho opened a new pull request, #15421:
URL: https://github.com/apache/nuttx/pull/15421

   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   Just adds enable/disable to timer low level ops.
   
   ## Impact
   
   No impact is expected
   
   ## Testing
   
   Tested on STM32G474 device.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #15421:
URL: https://github.com/apache/nuttx/pull/15421#issuecomment-2575564847

   Here is the fix: https://github.com/apache/nuttx/pull/15441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #15421:
URL: https://github.com/apache/nuttx/pull/15421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #15421:
URL: https://github.com/apache/nuttx/pull/15421#issuecomment-2575320330

   @xiaoxiang781216 any idea about this SEGGER_RTT error?
   ```
   ====================================================================================
   Cmake in present: nucleo-f446re/systemview,CONFIG_ARM_TOOLCHAIN_CLANG
   Configuration/Tool: nucleo-f446re/systemview,CONFIG_ARM_TOOLCHAIN_CLANG
   2025-01-07 12:28:58
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Select HOST_LINUX=y
     Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
     Enabling CONFIG_ARM_TOOLCHAIN_CLANG
     Building NuttX...
   [1/5] cd /github/workspace/sources/nuttx/build/libs/libc/misc && /usr/local/bin/cmake -E touch /github/workspace/sources/nuttx/libs/libc/misc/lib_utsname.c
   [2/5] Linking CXX executable nuttx
   FAILED: nuttx 
   : && /tools/ccache/bin/arm-none-eabi-g++  --specs=nosys.specs   -Wl,--print-memory-usage -Wl,--entry=__start -nostdlib -Wl,--gc-sections -Wl,--cref -Wl,-Map=nuttx.map @CMakeFiles/nuttx.rsp -o nuttx  && :
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_SendNumModules':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendNumModules+0x2): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendNumModules+0x2a): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_Start':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Start+0x8): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Start+0x16): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Start+0x20): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Start+0x5a): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_RecordVoid':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordVoid+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordVoid+0x16): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_RecordU32':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordU32+0x6): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordU32+0x24): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_RecordU32x2':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordU32x2+0x8): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordU32x2+0x32): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_Stop':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Stop+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_Stop+0x1e): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_GetSysDesc':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_GetSysDesc+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_GetSysDesc+0x3e): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_SendTaskInfo':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendTaskInfo+0x6): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendTaskInfo+0x88): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_SendSysDesc':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendSysDesc+0x6): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendSysDesc+0x22): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_RecordEnterISR':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordEnterISR+0x2): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordEnterISR+0x24): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_RecordExitISR':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordExitISR+0x2): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_RecordExitISR+0x14): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_OnIdle':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnIdle+0x2): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnIdle+0x14): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_OnTaskCreate':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskCreate+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskCreate+0x28): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_OnTaskTerminate':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskTerminate+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskTerminate+0x28): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_OnTaskStartExec':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskStartExec+0x4): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskStartExec+0x28): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_OnTaskStopExec':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskStopExec+0x2): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_OnTaskStopExec+0x14): undefined reference to `SEGGER_RTT_UNLOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: drivers/segger/libSystemView.a(SEGGER_SYSVIEW.c.obj): in function `SEGGER_SYSVIEW_SendModule':
   SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendModule+0x18): undefined reference to `SEGGER_RTT_LOCK'
   /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: SEGGER_SYSVIEW.c:(.text.SEGGER_SYSVIEW_SendModule+0x5a): undefined reference to `SEGGER_RTT_UNLOCK'
   Memory region         Used Size  Region Size  %age Used
              flash:      128076 B       512 KB     24.43%
               sram:       12148 B       128 KB      9.27%
   collect2: error: ld returned 1 exit status
   ninja: build stopped: subcommand failed.
   cp: cannot stat 'nuttx.hex': No such file or directory
   cp: cannot stat 'nuttx.bin': No such file or directory
   cp: cannot stat 'nuttx.hex': No such file or directory
   cp: cannot stat 'nuttx.bin': No such file or directory
   ====================================================================================
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #15421:
URL: https://github.com/apache/nuttx/pull/15421#issuecomment-2575586505

   let's ignore the ci error and merge the change directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #15421:
URL: https://github.com/apache/nuttx/pull/15421#discussion_r1901767705


##########
arch/arm/src/stm32/stm32_tim.c:
##########
@@ -360,6 +360,8 @@ static int  stm32_tim_checkint(struct stm32_tim_dev_s *dev, int source);
 
 static const struct stm32_tim_ops_s stm32_tim_ops =
 {
+  .enable     = stm32_tim_enable,

Review Comment:
   please modify also other stm32 chips



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/arm/stm32/: Added enable/disable to timer low level ops. [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15421:
URL: https://github.com/apache/nuttx/pull/15421#issuecomment-2573479008

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing, it lacks crucial details.
   
   Here's a breakdown of what's missing:
   
   * **Summary:**  While stating the change itself, the *why* is missing.  Is this for a specific use case? Does it fix a bug?  What timer driver is being modified?  How does the enable/disable mechanism work?  Are interrupts involved?  Are there any related issues?
   * **Impact:**  Claiming "no impact" is rarely true.  Even a small change like this can have unforeseen consequences.  Think about corner cases.  Does this affect power consumption?  Does it change the timing behavior in a subtle way? The PR author needs to justify the "no impact" assertion more thoroughly.
   * **Testing:** While a target is mentioned, the build host information is missing.  Crucially, the "before" and "after" logs are empty.  Without these logs, there's no evidence the change actually works or that it doesn't introduce regressions.  What tests were run? What were the expected results?
   
   To meet the requirements, the PR needs to be significantly expanded with the missing details.  Vague claims need to be replaced with concrete information and evidence.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org