You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/07/10 14:52:02 UTC

[GitHub] [hbase] meszibalu commented on a change in pull request #360: HBASE-15666 shaded dependencies for hbase-testing-util

meszibalu commented on a change in pull request #360: HBASE-15666 shaded dependencies for hbase-testing-util
URL: https://github.com/apache/hbase/pull/360#discussion_r302109040
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -2257,6 +2257,7 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
+      <scope>test</scope>
 
 Review comment:
   Ok, I will check it. It is definitely not a good idea to include junit to the compile classpath. It also caused some issues when shading testing-util. Do you remember how can I reproduce the issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services