You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/17 11:21:41 UTC

[GitHub] [airflow] ashb commented on a change in pull request #7740: [AIRFLOW-7065] Add optional propagation of task std streams to console

ashb commented on a change in pull request #7740: [AIRFLOW-7065] Add optional propagation of task std streams to console
URL: https://github.com/apache/airflow/pull/7740#discussion_r393607577
 
 

 ##########
 File path: airflow/utils/log/logging_mixin.py
 ##########
 @@ -58,21 +61,23 @@ def _set_context(self, context):
             set_context(self.log, context)
 
 
-# TODO: Formally inherit from io.IOBase
 
 Review comment:
   Why did you remove this todo? It should still be done in the future, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services