[GitHub] ShannonDing commented on a change in pull request #8: add one key build script to build static and share library

[GitBox <gi...@apache.org>]

ShannonDing commented on a change in pull request #8: add one key build script to build static and share library
URL: https://github.com/apache/rocketmq-client-cpp/pull/8#discussion_r234853885
 
 

 ##########
 File path: include/SendResult.h
 ##########
 @@ -34,21 +34,23 @@ enum SendStatus {
 class ROCKETMQCLIENT_API SendResult {
  public:
   SendResult();
-  SendResult(const SendStatus& sendStatus, const std::string& msgId,
+  SendResult(const SendStatus& sendStatus, const std::string& msgId, const std::string& offsetMsgId, 
 
 Review comment:
   It is better to overload its constructor. keep the old method and continue to use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services