You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2015/03/12 19:25:36 UTC
Review Request 31997: Cleanup waiter timers so we don't send an event
to a dead waiter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Bugs: MESOS-2484
https://issues.apache.org/jira/browse/MESOS-2484
Repository: mesos
Description
-------
Cleanup waiter timers so we don't send an event to a dead waiter
Follow up for 30587
Diffs
-----
3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
Diff: https://reviews.apache.org/r/31997/diff/
Testing
-------
`GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just metrics).
Thanks,
Cody Maloney
Re: Review Request 31997: Cleanup waiter timers so we don't send an
event to a dead waiter
Posted by Cody Maloney <co...@mesosphere.io>.
> On March 12, 2015, 6:29 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2875
> > <https://reviews.apache.org/r/31997/diff/1/?file=892303#file892303line2875>
> >
> > CHECK_SOME(timer)?
Added, Should be impossible to get there without timer being set because of libprocess initialization ordering, but always better safe than sorry.
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/#review76266
-----------------------------------------------------------
On March 12, 2015, 6:34 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31997/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 6:34 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-2484
> https://issues.apache.org/jira/browse/MESOS-2484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleanup waiter timers so we don't send an event to a dead waiter
>
> Follow up for 30587
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
>
> Diff: https://reviews.apache.org/r/31997/diff/
>
>
> Testing
> -------
>
> `GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just metrics).
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 31997: Cleanup waiter timers so we don't send an
event to a dead waiter
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/#review76266
-----------------------------------------------------------
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/31997/#comment123781>
CHECK_SOME(timer)?
- Dominic Hamon
On March 12, 2015, 11:25 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31997/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 11:25 a.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-2484
> https://issues.apache.org/jira/browse/MESOS-2484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleanup waiter timers so we don't send an event to a dead waiter
>
> Follow up for 30587
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
>
> Diff: https://reviews.apache.org/r/31997/diff/
>
>
> Testing
> -------
>
> `GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just metrics).
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 31997: Cleanup waiter timers so we don't send an
event to a dead waiter
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/#review76278
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31997]
All tests passed.
- Mesos ReviewBot
On March 12, 2015, 6:34 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31997/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 6:34 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-2484
> https://issues.apache.org/jira/browse/MESOS-2484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleanup waiter timers so we don't send an event to a dead waiter
>
> Follow up for 30587
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
>
> Diff: https://reviews.apache.org/r/31997/diff/
>
>
> Testing
> -------
>
> `GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just metrics).
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 31997: Cleanup waiter timers so we don't send an
event to a dead waiter
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/
-----------------------------------------------------------
(Updated March 12, 2015, 6:34 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Add CHECK_SOME() per Dominic's review
Bugs: MESOS-2484
https://issues.apache.org/jira/browse/MESOS-2484
Repository: mesos
Description
-------
Cleanup waiter timers so we don't send an event to a dead waiter
Follow up for 30587
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
Diff: https://reviews.apache.org/r/31997/diff/
Testing
-------
`GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just metrics).
Thanks,
Cody Maloney