You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/06 06:12:18 UTC

[GitHub] [flink] rkhachatryan commented on pull request #13067: [FLINK-18821][network] Report PartitionRequest failures to subsequent…

rkhachatryan commented on pull request #13067:
URL: https://github.com/apache/flink/pull/13067#issuecomment-669724084


   Yes, you are right, exceptionally completed future stays in the map.
   But I think this was the original intention in `PartitionRequestClientFactory`. Otherwise, new requests would retry again almost immediately.
   
   I think ideally such a future should be removed after some delay (regardless of client requests). But this seems to be out of scope of this PR (which removes indefinite wait). WDYT about addressing it separately?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org