You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 18:18:54 UTC
[GitHub] [airflow] subkanthi opened a new pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
subkanthi opened a new pull request #21999:
URL: https://github.com/apache/airflow/pull/21999
Added support to override auth_type in auth_file in pgbouncer helm configuration
closes: #19654
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
subkanthi commented on pull request #21999:
URL: https://github.com/apache/airflow/pull/21999#issuecomment-1068000604
Resolved conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21999:
URL: https://github.com/apache/airflow/pull/21999#issuecomment-1079764081
Merged @subkanthi :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
subkanthi commented on pull request #21999:
URL: https://github.com/apache/airflow/pull/21999#issuecomment-1079703355
Can this one be merged. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21999:
URL: https://github.com/apache/airflow/pull/21999#discussion_r822327589
##########
File path: chart/values.schema.json
##########
@@ -3327,6 +3327,16 @@
"type": "integer",
"default": 0
},
+ "auth_type": {
+ "description": "Method of Authenticating users",
Review comment:
```suggestion
"description": "Method of authenticating users",
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21999:
URL: https://github.com/apache/airflow/pull/21999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21999:
URL: https://github.com/apache/airflow/pull/21999#issuecomment-1060105891
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org