[GitHub] [incubator-heron] joshfischer1108 commented on a change in pull request #3725: [Heron-3723] Add support for Persistent Volumes for stateful storage

[GitBox <gi...@apache.org>]

joshfischer1108 commented on a change in pull request #3725:
URL: https://github.com/apache/incubator-heron/pull/3725#discussion_r748516945



##########
File path: website2/docs/schedulers-k8s-persistent-volume-claims.md
##########
@@ -24,7 +24,9 @@ sidebar_label: Kubernetes Persistent Volume Claims (CLI)
 
 <br/>
 
-It is possible to leverage Persistent Volumes with custom Pod Templates. The CLI commands allow you to configure a Persistent Volume Claim (dynamically or statically backed) when you submit your topology. They also permit you to configure a Persistent Volume without a custom Pod Template. The CLI commands override any configurations you may have present in the Pod Template, but Heron's configurations will take precedence over all others.
+It is possible to leverage Persistent Volumes with custom Pod Templates but the Volumes you add will be shared amongst all Pods in the topology. Please leverage Pod Templates if you require Volumes which are shared amongst the entire topology.
+
+The CLI commands allow you to configure a Persistent Volume Claim (dynamically or statically backed) which will be unique and isolated to each Pod and mounted in a single `Executor` when you submit your topology. They also permit you to configure a Persistent Volume without a custom Pod Template which will be specific to an individual Pod. The CLI commands override any configurations you may have present in the Pod Template, but Heron's configurations will take precedence over all others.

Review comment:
       It would be good to describe why someone would use a persistent volume claim with Heron.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org