You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/04 03:33:14 UTC
[jira] Created: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
[classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
-------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-1063
URL: http://issues.apache.org/jira/browse/HARMONY-1063
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Andrew Zhang
java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
Following test reproduces the bug:
public void test_responseCode () throws Exception {
URI uri = new URI("http://a@");
System.out.println("uri = "+uri.getHost());
ProxySelector selector = ProxySelector.getDefault();
selector.select(uri);
}
The test passes against RI while fails against Harmony.
I'll upload a patch to fix this problem soon.
Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1063?page=all ]
Paulex Yang resolved HARMONY-1063.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r428620, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1063
> URL: http://issues.apache.org/jira/browse/HARMONY-1063
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> Following test reproduces the bug:
> public void test_responseCode () throws Exception {
> URI uri = new URI("http://a@");
> System.out.println("uri = "+uri.getHost());
> ProxySelector selector = ProxySelector.getDefault();
> selector.select(uri);
> }
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1063?page=all ]
Paulex Yang reassigned HARMONY-1063:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1063
> URL: http://issues.apache.org/jira/browse/HARMONY-1063
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> Following test reproduces the bug:
> public void test_responseCode () throws Exception {
> URI uri = new URI("http://a@");
> System.out.println("uri = "+uri.getHost());
> ProxySelector selector = ProxySelector.getDefault();
> selector.select(uri);
> }
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1063?page=all ]
Andrew Zhang updated HARMONY-1063:
----------------------------------
Attachment: luni.diff
Hi,
Would you please try my patch?
The patch also changes MockProxySelector.select return type "List" to "List <Proxy>" in ProxySelectorTest.java.
Thanks!
Best regards,
Andrew
> [classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1063
> URL: http://issues.apache.org/jira/browse/HARMONY-1063
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: luni.diff
>
>
> java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> Following test reproduces the bug:
> public void test_responseCode () throws Exception {
> URI uri = new URI("http://a@");
> System.out.println("uri = "+uri.getHost());
> ProxySelector selector = ProxySelector.getDefault();
> selector.select(uri);
> }
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1063?page=comments#action_12425675 ]
Andrew Zhang commented on HARMONY-1063:
---------------------------------------
Hi Paulex,
The fix looks fine, thank you!
Best regards,
Andrew
> [classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1063
> URL: http://issues.apache.org/jira/browse/HARMONY-1063
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> Following test reproduces the bug:
> public void test_responseCode () throws Exception {
> URI uri = new URI("http://a@");
> System.out.println("uri = "+uri.getHost());
> ProxySelector selector = ProxySelector.getDefault();
> selector.select(uri);
> }
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1063) [classlib][luni]
java.net.ProxySelector.select(URI uri) throws unexpected
IllegalArgumentException when uri.host is null.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1063?page=all ]
Paulex Yang closed HARMONY-1063.
--------------------------------
Verified by Andrew.
> [classlib][luni] java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1063
> URL: http://issues.apache.org/jira/browse/HARMONY-1063
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.ProxySelector.select(URI uri) throws unexpected IllegalArgumentException when uri.host is null.
> Following test reproduces the bug:
> public void test_responseCode () throws Exception {
> URI uri = new URI("http://a@");
> System.out.println("uri = "+uri.getHost());
> ProxySelector selector = ProxySelector.getDefault();
> selector.select(uri);
> }
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira