You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Deepak Jaiswal <dj...@hortonworks.com> on 2018/06/22 22:07:30 UTC

Review Request 67710: HIVE-19481

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67710/
-----------------------------------------------------------

Review request for hive, Jason Dere and Sergey Shelukhin.


Bugs: HIVE-19481
    https://issues.apache.org/jira/browse/HIVE-19481


Repository: hive-git


Description
-------

sample10.q returns wrong results.
Multiple issues were fixed
1. Instead of using old MR logic which assumes there is 1 file for each bucket, lookup buckets by name(non-managed tables)
2. Skip bucket pruning for managed tables.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 9dbd869d57 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java 8200e6a237 
  ql/src/test/queries/clientpositive/sample10_mm.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/sample10.q.out 1b95314980 
  ql/src/test/results/clientpositive/llap/sample10_mm.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/spark/sample10.q.out ac28779591 


Diff: https://reviews.apache.org/r/67710/diff/1/


Testing
-------


Thanks,

Deepak Jaiswal


Re: Review Request 67710: HIVE-19481

Posted by Deepak Jaiswal <dj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67710/
-----------------------------------------------------------

(Updated June 25, 2018, 6:15 p.m.)


Review request for hive, Jason Dere and Sergey Shelukhin.


Changes
-------

Updated results for failed tests.


Bugs: HIVE-19481
    https://issues.apache.org/jira/browse/HIVE-19481


Repository: hive-git


Description
-------

sample10.q returns wrong results.
Multiple issues were fixed
1. Instead of using old MR logic which assumes there is 1 file for each bucket, lookup buckets by name(non-managed tables)
2. Skip bucket pruning for managed tables.


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties 517b413839 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 9dbd869d57 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java 8200e6a237 
  ql/src/test/queries/clientpositive/sample10_mm.q PRE-CREATION 
  ql/src/test/results/clientpositive/archive_excludeHadoop20.q.out e4b390c9cd 
  ql/src/test/results/clientpositive/beeline/smb_mapjoin_11.q.out 9f946e0b50 
  ql/src/test/results/clientpositive/llap/sample10.q.out ce3c2880a6 
  ql/src/test/results/clientpositive/llap/sample10_mm.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_5.q.out 498fc117c7 
  ql/src/test/results/clientpositive/sample6.q.out 7f853e55c5 
  ql/src/test/results/clientpositive/sample7.q.out 0e2fc287d4 
  ql/src/test/results/clientpositive/sample9.q.out 0de49a698a 
  ql/src/test/results/clientpositive/smb_mapjoin_11.q.out a83f3e66c4 
  ql/src/test/results/clientpositive/spark/infer_bucket_sort_bucketed_table.q.out 8fab7ecbd0 
  ql/src/test/results/clientpositive/spark/sample10.q.out 555e5f43ec 
  ql/src/test/results/clientpositive/spark/sample2.q.out 8b73fdf874 
  ql/src/test/results/clientpositive/spark/sample4.q.out 3269b015ec 
  ql/src/test/results/clientpositive/spark/sample6.q.out 36532d7fbe 
  ql/src/test/results/clientpositive/spark/sample7.q.out d0b52bcdce 


Diff: https://reviews.apache.org/r/67710/diff/2/

Changes: https://reviews.apache.org/r/67710/diff/1-2/


Testing
-------


Thanks,

Deepak Jaiswal