You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2018/03/17 02:44:55 UTC
[kudu-CR] KUDU-2346: Fix mac pkg-config issue.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9652
to look at the new patch set (#7).
Change subject: KUDU-2346: Fix mac pkg-config issue.
......................................................................
KUDU-2346: Fix mac pkg-config issue.
Previously an empty return string from pkg-config --cflags was used
as a proxy for testing if the package was installed. The Macos version
of pkg-config returns an error message in response to this command
when a package is not installed.
The fix is to property test the return value of pkg-config --cflags.
Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
---
M thirdparty/build-thirdparty.sh
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9652/7
--
To view, visit http://gerrit.cloudera.org:8080/9652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 7
Gerrit-Owner: tigerquoll@outlook.com
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: tigerquoll@outlook.com