[GitHub] [iceberg] huaxingao commented on a diff in pull request #5313: Orc: Support row group bloom filters

[GitBox <gi...@apache.org>]

huaxingao commented on code in PR #5313:
URL: https://github.com/apache/iceberg/pull/5313#discussion_r949839922


##########
orc/src/main/java/org/apache/iceberg/orc/ORC.java:
##########
@@ -220,6 +224,10 @@ private static class Context {
       private final CompressionKind compressionKind;
       private final CompressionStrategy compressionStrategy;
 
+      private final String bloomFilterColumns;
+
+      private final double bloomFilterFpp;

Review Comment:
   nit: shall we remove the blank lines in L226 and L228 so `bloomFilterColumns` and `bloomFilterFpp` will be grouped together with the rest of the properties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org