You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/03/17 06:27:58 UTC

Re: Review Request 26581: SQOOP-1156: HBase connector TO direction

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------

(Updated March 17, 2015, 5:27 a.m.)


Review request for Sqoop.


Bugs: SQOOP-1156
    https://issues.apache.org/jira/browse/SQOOP-1156


Repository: sqoop-sqoop2


Description
-------

commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Thu Oct 9 22:56:34 2014 -0700

    SQOOP-1156: HBase connector

:000000 100644 0000000... 61dd408... A  connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A  connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A  connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A  connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M  connector/pom.xml
:100644 100644 f25a29f... a556bcf... M  pom.xml
:100644 100644 67baaa5... 21a1fa9... M  server/pom.xml
:100644 100644 7a80710... fbd4e84... M  test/pom.xml


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/validation/validators/PortOrNull.java PRE-CREATION 
  connector/connector-hbase/pom.xml PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/asserts/HBaseAsserts.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION 
  connector/connector-hbase/src/main/resources/hbase-connector-config.properties PRE-CREATION 
  connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION 
  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION 
  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION 
  connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java e3068f0 
  connector/pom.xml dfa7e88 
  pom.xml 32afc77 
  server/pom.xml ee409cb 
  test/pom.xml f743d25 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e 
  test/src/main/java/org/apache/sqoop/test/testcases/HBaseConnectorTestCase.java PRE-CREATION 
  test/src/test/java/org/apache/sqoop/integration/connector/hbase/FromRDBMSToHBaseTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/26581/diff/


Testing
-------

mvn clean verify + can transfer from mysql to hbase.


Thanks,

Abraham Elmahrek


Re: Review Request 26581: SQOOP-1156: HBase connector TO direction

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26581/
-----------------------------------------------------------

(Updated March 17, 2015, 5:28 a.m.)


Review request for Sqoop.


Bugs: SQOOP-1156
    https://issues.apache.org/jira/browse/SQOOP-1156


Repository: sqoop-sqoop2


Description
-------

commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Thu Oct 9 22:56:34 2014 -0700

    SQOOP-1156: HBase connector

:000000 100644 0000000... 61dd408... A  connector/connector-hbase/pom.xml
:000000 100644 0000000... b0e4ea0... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java
:000000 100644 0000000... 975cb40... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java
:000000 100644 0000000... 2e08bfd... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java
:000000 100644 0000000... cf632c9... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java
:000000 100644 0000000... bc61993... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java
:000000 100644 0000000... 991846f... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java
:000000 100644 0000000... 325591c... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java
:000000 100644 0000000... 51fd885... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java
:000000 100644 0000000... 6e306b1... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java
:000000 100644 0000000... a4b825c... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java
:000000 100644 0000000... 15feb54... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java
:000000 100644 0000000... cc71b78... A  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java
:000000 100644 0000000... 15a9425... A  connector/connector-hbase/src/main/resources/hbase-connector-resources.properties
:000000 100644 0000000... 1fc360e... A  connector/connector-hbase/src/main/resources/sqoopconnector.properties
:000000 100644 0000000... c78042a... A  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java
:000000 100644 0000000... 60f8217... A  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java
:000000 100644 0000000... 44ffced... A  connector/connector-hbase/src/test/resources/log4j.properties
:100644 100644 e98a0fc... 35c665e... M  connector/pom.xml
:100644 100644 f25a29f... a556bcf... M  pom.xml
:100644 100644 67baaa5... 21a1fa9... M  server/pom.xml
:100644 100644 7a80710... fbd4e84... M  test/pom.xml


Diffs
-----

  common/src/main/java/org/apache/sqoop/validation/validators/PortOrNull.java PRE-CREATION 
  connector/connector-hbase/pom.xml PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/asserts/HBaseAsserts.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java PRE-CREATION 
  connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java PRE-CREATION 
  connector/connector-hbase/src/main/resources/hbase-connector-config.properties PRE-CREATION 
  connector/connector-hbase/src/main/resources/sqoopconnector.properties PRE-CREATION 
  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java PRE-CREATION 
  connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java PRE-CREATION 
  connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java e3068f0 
  connector/pom.xml dfa7e88 
  pom.xml 32afc77 
  server/pom.xml ee409cb 
  test/pom.xml f743d25 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e 
  test/src/main/java/org/apache/sqoop/test/testcases/HBaseConnectorTestCase.java PRE-CREATION 
  test/src/test/java/org/apache/sqoop/integration/connector/hbase/FromRDBMSToHBaseTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/26581/diff/


Testing (updated)
-------

mvn clean verify + can transfer from mysql to hbase.

Added integration test case.


Thanks,

Abraham Elmahrek