You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/30 13:15:07 UTC

[GitHub] [apisix-dashboard] okaybase commented on pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin

okaybase commented on pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#issuecomment-889885551


   > Nice improve for UE~!
   > 
   > @okaybase would you please add corresponding test case for your feature?
   > 
   > That will help us merge your pr smoothly, thanks
   
   the test cases added. 
   thanks for your review~ @liuxiran @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org