[GitHub] [pinot] klsince commented on a change in pull request #8242: handle lineage with empty segmentsFrom

[GitBox <gi...@apache.org>]

klsince commented on a change in pull request #8242:
URL: https://github.com/apache/pinot/pull/8242#discussion_r814286506



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2883,10 +2883,9 @@ public String startReplaceSegments(String tableNameWithType, List<String> segmen
           // 2. Proactively delete the oldest data snapshot to make sure that we only keep at most 2 data snapshots
           //    at any time in case of REFRESH use case.
           if (forceCleanup) {
-            if (lineageEntry.getState() == LineageEntryState.IN_PROGRESS && !Collections
-                .disjoint(segmentsFrom, lineageEntry.getSegmentsFrom())) {

Review comment:
       hey folks, I accidentally pushed my change of using disjoint() in https://github.com/apache/pinot/pull/8240/files. Tests seemed fine with that more strict check. 
   
   But I'm reverting it back here to keep this PR focused. If that's actually a right move, I'll add it back in following PR with more proper UT cases. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org