You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/06/01 17:51:41 UTC

[GitHub] [superset] john-bodley commented on a diff in pull request #24197: chore(pre-commit): Add pyupgrade and pycln hooks

john-bodley commented on code in PR #24197:
URL: https://github.com/apache/superset/pull/24197#discussion_r1213491874


##########
.pre-commit-config.yaml:
##########
@@ -15,14 +15,26 @@
 # limitations under the License.
 #
 repos:
+  - repo: https://github.com/MarcoGorelli/auto-walrus
+    rev: v0.2.2
+    hooks:
+      - id: auto-walrus
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v3.4.0
+    hooks:
+      - id: pyupgrade
+        args:
+          - --keep-runtime-typing
+          - --py38-plus
+  - repo: https://github.com/hadialqattan/pycln

Review Comment:
   @michael-s-molina yes. Per the `--py39-plus` CLI argument it ensures that the changes are compatible with Python versions >= 3.9 which is the minimum version we currently support.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org