You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/05/30 15:44:54 UTC

[GitHub] [cxf] reta opened a new pull request #807: CXF-8532: @Priority support for ParamConverterProvider

reta opened a new pull request #807:
URL: https://github.com/apache/cxf/pull/807


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

Posted by GitBox <gi...@apache.org>.
reta commented on pull request #807:
URL: https://github.com/apache/cxf/pull/807#issuecomment-851032575


   @andymc12 mind please taking a look? Also, I've noticed `MicroProfileClientProviderFactory::createComparator` does not take `@Priority` into account for providers, it is not required by spec? (sorry didn't have time to check it myself).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] andymc12 commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

Posted by GitBox <gi...@apache.org>.
andymc12 commented on pull request #807:
URL: https://github.com/apache/cxf/pull/807#issuecomment-851036854


   Hi @reta - I'm on holiday today and tomorrow, but I'll take a look when I
   get back.  IIRC, MP Rest Client should take `@Priority` into account, but
   maybe it isn't tested in the TCK (or maybe we've just been passing so far
   by luck?).  Thanks for catching this!
   
   On Sun, May 30, 2021 at 12:19 PM Andriy Redko ***@***.***>
   wrote:
   
   > @andymc12 <https://github.com/andymc12> mind please taking a look? Also,
   > I've noticed MicroProfileClientProviderFactory::createComparator does not
   > take @Priority into account for providers, it is not required by spec?
   > (sorry didn't have time to check it myself).
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/cxf/pull/807#issuecomment-851032575>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AFDAEMY5N7TPKBQ6B5VM2TDTQJXQZANCNFSM45ZPKWDA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

Posted by GitBox <gi...@apache.org>.
reta commented on pull request #807:
URL: https://github.com/apache/cxf/pull/807#issuecomment-852465250


   Thanks a mill, @andymc12 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta merged pull request #807: CXF-8532: @Priority support for ParamConverterProvider

Posted by GitBox <gi...@apache.org>.
reta merged pull request #807:
URL: https://github.com/apache/cxf/pull/807


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta commented on pull request #807: CXF-8532: @Priority support for ParamConverterProvider

Posted by GitBox <gi...@apache.org>.
reta commented on pull request #807:
URL: https://github.com/apache/cxf/pull/807#issuecomment-851717489


   @andymc12 my apologies, double-checked the implementation, the `MicroProfileClientProviderFactory::createComparator` is all set, it uses `ContractComparator` which uses the delegating comparator (the one which confused me) but itself check the priorities. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org